Use the router to get the correct path from the connect facebook check route #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
README.md
Outdated
| @@ -266,7 +266,7 @@ class MyFacebookAuthenticator extends SocialAuthenticator | |||
| public function supports(Request $request) | |||
| { | |||
| // continue ONLY if the URL matches the check URL | |||
| return $request->getPathInfo() == '/connect/facebook/check'; | |||
| return $request->getPathInfo() == $this->router->getRouteCollection()->get('connect_facebook_check')->getPath(); | |||
There was a problem hiding this comment.
Why don't just $this->router->generate('connect_facebook_check')?
There was a problem hiding this comment.
would add a host when the route has a host defined or?
There was a problem hiding this comment.
It shouldn't add a host, but I'm actually not sure if you have the host defined - good point :).
But, there another option anyways, where we look specifically at the route name:
return $request->attributes->get('_route') == 'connect_facebook_check';Do you guys like that better?
There was a problem hiding this comment.
Looks good for me did update the PR
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent problems like: #39